Verify binaries while creating release blog post #186
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment of creating the release blog post, there's a chance not all binaries has been uploaded to nodejs.org/dist/ yet.
In these circumstances those specific binaries should have "Coming soon" rather than the actual download URL as those URLs would fail with a 404 page anyway.
This change enables that behaviour by verifying all the binaries about to be included in the blog post, by doing a HEAD request against each of the URLs where they're supposed to be located.
Refs #156
cc @nodejs/release