test: Add test covg for Maybe<T> #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
approved these changes
Jan 16, 2023
test/maybe/check.cc
Outdated
| @@ -6,18 +7,63 @@ using namespace Napi; | |||
| namespace { | |||
|
|
|||
| void VoidCallback(const CallbackInfo& info) { | |||
| Function fn = info[0].As<Function>(); | |||
| Napi::Function fn = info[0].As<Function>(); | |||
| Maybe<Value> fn_m = fn.Call({}); | |||
There was a problem hiding this comment.
This variable represents the return value of the fn invocation. Might be worth to name it with prefix like ret, rather than fn.
Suggested change
| Maybe<Value> fn_m = fn.Call({}); | |
| Maybe<Value> ret_m = fn.Call({}); |
There was a problem hiding this comment.
Updated the PR to fix this.
…n-api into add-test-covg-for-maybe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test coverage for #1046