Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,chore: drop support for Node.js v14, v19 #1324

Merged
merged 2 commits into from
Jun 13, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/workflows/ci-win.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,11 @@ jobs:
timeout-minutes: 30
strategy:
matrix:
node-version: [ 14.x, 16.x, 18.x, 19.x ]
node-version: [ 16.x, 18.x, 20.x ]
architecture: [x64, x86]
os:
- windows-2019
- windows-2022
exclude:
- node-version: 14.x
os: windows-2022 # Node.JS 14.x GYP does not support Visual Studio 2022
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
timeout-minutes: 30
strategy:
matrix:
node-version: [ 14.x, 16.x, 18.x, 19.x ]
node-version: [ 16.x, 18.x, 20.x ]
os:
- macos-latest
- ubuntu-latest
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ This allows addons built with it to run with Node.js versions which support the
**However** the node-addon-api support model is to support only the active LTS Node.js versions. This means that
every year there will be a new major which drops support for the Node.js LTS version which has gone out of service.

The oldest Node.js version supported by the current version of node-addon-api is Node.js 14.x.
The oldest Node.js version supported by the current version of node-addon-api is Node.js 18.x.
KevinEady marked this conversation as resolved.
Show resolved Hide resolved

## Setup
- [Installation and usage](doc/setup.md)
Expand Down Expand Up @@ -275,6 +275,7 @@ available:
![Node-API v6 Badge](https://github.com/nodejs/abi-stable-node/blob/doc/assets/Node-API%20v6%20Badge.svg)
![Node-API v7 Badge](https://github.com/nodejs/abi-stable-node/blob/doc/assets/Node-API%20v7%20Badge.svg)
![Node-API v8 Badge](https://github.com/nodejs/abi-stable-node/blob/doc/assets/Node-API%20v8%20Badge.svg)
![Node-API v9 Badge](https://github.com/nodejs/abi-stable-node/blob/doc/assets/Node-API%20v9%20Badge.svg)
![Node-API Experimental Version Badge](https://github.com/nodejs/abi-stable-node/blob/doc/assets/Node-API%20Experimental%20Version%20Badge.svg)

## **Contributing**
Expand Down
21 changes: 21 additions & 0 deletions doc/creating_a_release.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,24 @@ and that the correct version is installed.
and close the issue.

* Tweet that the release has been created.

## Optional Steps

Depending on circumstances for the release, additional steps may be required to
support the release process.

### Major Releases to Drop Support Node.js Versions

`node-addon-api` provides support for Node.js versions following the same
[release schedule](https://nodejs.dev/en/about/releases/): once a Node.js
version leaves maintenance mode, the next major version of `node-addon-api`
published will drop support for that version. These are the steps to follow to
drop support for a Node.js version:

* Update minimum version supported in documentation ([README.md](../README.md))

* Remove from GitHub actions ([ci.yml](../.github/workflows/ci.yml) and
[ci-win.yml](../.github/workflows/ci-win.yml))

* Remove from Jenkins CI ([node-test-node-addon-api-LTS versions
[Jenkins]](https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-LTS%20versions/))