Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide def file for windows import lib #17

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Conversation

Pospelove
Copy link
Contributor

@Pospelove Pospelove commented Mar 17, 2023

closes #15

example PR created by updated workflow: Pospelove#2

@Pospelove
Copy link
Contributor Author

let's merge

@Pospelove
Copy link
Contributor Author

@mhdawson @legendecas

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work. Looks good to me.

@vmoroz and @NickNaso mentioned that they are able to take a look at this. As this has been open for weeks, I'll land this as is tomorrow if no changes are requested.

@legendecas legendecas merged commit d23c287 into nodejs:main Mar 29, 2023
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Pospelove,
maybe it could be better to put the definition files in a folder like def and then update the index.js in something like repoterd below:

'use strict'

const path = require('path');
const symbols = require('./symbols')

const include_dir = path.resolve(__dirname, 'include');

const js_native_def = path.resolve(__dirname, 'def','js_native_api.def');
const node_api_def = path.resolve(__dirname, 'def', 'node_api.def');
const def = {
    js_native_def,
    node_api_def
}

module.exports = {
    include_dir,
    symbols,
    def
}

What do you think about?
If you agree with my proposal please update the documentation https://github.com/nodejs/node-api-headers/pulls#api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide def file for windows import lib
4 participants