improved documentation and fix on include_dir. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinEady
reviewed
Aug 20, 2021
|
Would using |
KevinEady
requested changes
Aug 23, 2021
- fixed typos - used path.resolve instead of path.relative.
@KevinEady I made the requested changes. Please take a look when you have time. |
KevinEady
reviewed
Aug 27, 2021
mhdawson
approved these changes
Aug 27, 2021
There was a problem hiding this comment.
LGTM once the outstanding comments from @KevinEady and @gabrielschulhof are addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3
Added more documentation about node-api-headers
Fixed the
include_dirproperty.