This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
chakrashim,test: fix Promise API compatibility #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
MSLaguana
reviewed
May 11, 2018
| @@ -547,6 +547,7 @@ | |||
| }; | |||
|
|
|||
| utils.isPromise = function(obj) { | |||
There was a problem hiding this comment.
Since this isn't referenced any more (right?) can it be removed completely?
There was a problem hiding this comment.
It's still use here: https://github.com/nodejs/node-chakracore/pull/537/files#diff-55320053aaa0abe61795d171a27dcbc8L403
I believe that code path is no longer used as well, but I didn't want to mess with that right now.
MSLaguana
approved these changes
May 11, 2018
sethbrenith
approved these changes
May 11, 2018
kfarnung
force-pushed
the
promises
branch
2 times, most recently
from
5419507
to
bd06de6
Compare
PR-URL: nodejs#537 Reviewed-By: Jimmy Thomson <[email protected]> Reviewed-By: Seth Brenith <[email protected]>
Update the shim to use the new `JsGetPromiseResult` and `JsGetPromiseState` APIs for the `v8::Promise` shim. PR-URL: nodejs#537 Reviewed-By: Jimmy Thomson <[email protected]> Reviewed-By: Seth Brenith <[email protected]>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
May 22, 2018
Update the shim to use the new `JsGetPromiseResult` and `JsGetPromiseState` APIs for the `v8::Promise` shim. PR-URL: nodejs#537 Reviewed-By: Jimmy Thomson <[email protected]> Reviewed-By: Seth Brenith <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the shim to use the new
JsGetPromiseResultandJsGetPromiseStateAPIs for thev8::Promiseshim.NOTE: the changes to ChakraCore are being reviewed separately chakra-core/ChakraCore#5131NOTE: waiting for chakra-core/ChakraCore#5138Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes