This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
Trigger GC when idle #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @nodejs/node-chakracore |
| @@ -84,6 +86,9 @@ class IsolateShim { | |||
| void DisableExecution(); | |||
| bool IsExeuctionDisabled(); | |||
| void EnableExecution(); | |||
| static inline bool ShouldScheduleIdleGc() { | |||
| return v8::g_shouldScheduleIdleGc; | |||
|
LGTM |
Added a task in prepare queue that will schedule `IdleGC` task if there is no idleGc task currently scheduled or if there was some javascript script execution happened. `IdleGC` will basically call [JsIdle](https://github.com/Microsoft/ChakraCore/wiki/JsIdle) and if it didn't succeed, it will schedule another `IdleGC` task after (nextTick - currentTick) ms. If this task succeeded, we don't have to do anything and next time prepareQueue task will be executed, it will decide if it should re-schedule `IdleGC` or not. Also include flag `--off_idlegc` to turn idleGC feature off. PR-URL: nodejs#77 Reviewed-By: Curtis Man <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
deps,src
Description of change
Chakracore has JsIdle API that a host can trigger to perform memory cleanp tasks whenever it is idle. In order to achieve this added a scheduler that will schedule idle GC in prepare queue after 1 second the last script execution started. When there are no more scripts to execute, task in
prepare queuewould get executed which will triggerJsIdle.JsIdlereturns tickCount until there will be more idle work to do. It can also return maximum tickCount that signifies that there is no idle work to perform. Based on the return value of this API, decide whether there is a needto reschedule another
JsIdleor not.With this implementation chakrashim takes dependency on
libuv.