Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"No full CI runs" warning #225

Closed
vsemozhetbyt opened this issue Apr 1, 2018 · 2 comments
Closed

"No full CI runs" warning #225

vsemozhetbyt opened this issue Apr 1, 2018 · 2 comments
Labels
bug pr-checker Issues related to pr checker

Comments

@vsemozhetbyt
Copy link
Contributor

Not sure if this is intended, but since the last update this warning appears even for PR warrantable for CI-lite:
nodejs/node#19721

√  Requested Changes: 0
√  Approvals: 3, 1 from TSC (cjihrig)
×  No full CI runs detected
i  Last Lite CI on 2018-04-01T07:36:06Z: https://ci.nodejs.org/job/node-test-pull-request-lite/375/
‼  This PR is being fast-tracked, but awating a CI run
@priyank-p priyank-p assigned priyank-p and unassigned priyank-p Apr 2, 2018
@priyank-p priyank-p added bug pr-checker Issues related to pr checker labels Apr 2, 2018
@priyank-p
Copy link
Contributor

Here is the code that we need to fix, need to add Lite category in the check as well:

} else if (!ciMap.get(FULL)) {
status = false;
cli.error('No full CI runs detected');
}

I think it's okay to add LITE category as trusted and not change the status right?

@joyeecheung
Copy link
Member

I think it's okay to add LITE category as trusted and not change the status right?

SGTM

priyank-p added a commit to priyank-p/node-core-utils that referenced this issue Apr 2, 2018
priyank-p added a commit that referenced this issue Apr 3, 2018
johnfrench3 pushed a commit to johnfrench3/core-utils-node that referenced this issue Nov 2, 2022
renawolford6 added a commit to renawolford6/node-dev-build-core-utils that referenced this issue Nov 10, 2022
Developerarif2 pushed a commit to Developerarif2/node-core-utils that referenced this issue Jan 27, 2023
gerkai added a commit to gerkai/node-core-utils-project-build that referenced this issue Jan 27, 2023
shovon58 pushed a commit to shovon58/node-core-utils that referenced this issue Jun 9, 2023
patrickm68 added a commit to patrickm68/NodeJS-core-utils that referenced this issue Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug pr-checker Issues related to pr checker
Projects
None yet
Development

No branches or pull requests

3 participants