Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SyntaxError: from __future__ imports must occur at the beginning of the file #1774

Closed
paulmdavies opened this issue Jun 13, 2019 · 1 comment
Closed

SyntaxError: from __future__ imports must occur at the beginning of the file #1774

paulmdavies opened this issue Jun 13, 2019 · 1 comment

Comments

@paulmdavies
Copy link

paulmdavies commented Jun 13, 2019 •
edited
Loading

The most recent release (released to npm today) doesn't work because of some python formatting issues:

SyntaxError: from __future__ imports must occur at the beginning of the file

This can be seen simply by checking out the repo and doing:

python <repo location>/gyp/tools/pretty_vcproj.py

or

python <repo location>/gyp/tools/pretty_sln.py

It's a problem with both python 2 and python 3.
@paulmdavies paulmdavies changed the title Python SyntaxError: from __future__ imports must occur at the beginning of the file Jun 13, 2019
@paulmdavies paulmdavies mentioned this issue Jun 13, 2019
Closed
@rvagg
Copy link
Member

rvagg commented Jun 20, 2019

@cclauss, @refack, halp!

cclauss added a commit to cclauss/node-gyp that referenced this issue Jun 20, 2019
@cclauss
move from __future__ import to the top of the file
e1f5a30 
Fixes nodejs#1774
@cclauss cclauss mentioned this issue Jun 20, 2019
Closed
4 tasks
@rvagg rvagg closed this as completed in 2cf1f78 Jun 21, 2019
rvagg pushed a commit that referenced this issue Jun 21, 2019
@cclauss @rvagg
gyp: move from __future__ import to the top of the file
f952b08 
Fixes #1774
PR-URL: #1789
Reviewed-By: Rod Vagg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move from __future__ import to the top of the file cclauss/node-gyp
2 participants
@rvagg @paulmdavies