-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix escaping -I includes when path contains spaces #1038
base: main
Are you sure you want to change the base?
Conversation
We've been hit by this issue today and were quite surprised to discover it's an ancient bug in node-gyp. Any reason why this can't be merged and #65 fixed? |
Hadn't seen this until today but it's at best a partial fix for #65. I didn't do a full audit but things like linker paths and source lists are also affected and probably more. |
Thanks for looking at this! Unless the partial fix breaks something else, and it doesn't seem likely, perhaps it's a good step into the direction of supporting spaces in build paths? The alternative could be a clear notice somewhere in the README, noting the lack of support. |
Any news about this? I can't install gyp because I have a space in my hdd name |
@refack should we pursue this here or https://github.com/refack/GYP, I don't even know anymore |
Please get this space thing fixed - super annoying if testing infrastructure contains spaces ... u know to test stability for spaces :D |
Fixes #65