Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some Python 3 fixes to node-gyp #1150

Merged
merged 6 commits into from
Oct 14, 2018
Merged

Add some Python 3 fixes to node-gyp #1150

merged 6 commits into from
Oct 14, 2018

Conversation

rodrigc
Copy link
Contributor

@rodrigc rodrigc commented Mar 19, 2017

This doesn't fully port node-gyp to Python 3,
but it provides some fixes which bring it in the direction which makes
doing a full port to Python 3 easier.

@cclauss
Copy link
Contributor

cclauss commented May 13, 2018

@refack Your review please?

@refack
Copy link
Contributor

refack commented Oct 14, 2018

Superseded by #1335
@rodrigc thank you very much for the contribution!

@refack refack closed this Oct 14, 2018
@eirnym
Copy link

eirnym commented Oct 14, 2018

@refack It was too fast as syntax changes are not all changes required.
@rodrigc I'll cherry-pick or take some of your commits.

@refack
Copy link
Contributor

refack commented Oct 14, 2018

@refack It was too fast as syntax changes are not all changes required.
@rodrigc I'll cherry-pick or take some of your commits.

Since the code works (that is I'm able to test GYP with python 3.6), I'm assuiming other changes are optional, or are at edge cases.

But I'll try to rebase.

@refack refack reopened this Oct 14, 2018
@eirnym
Copy link

eirnym commented Oct 14, 2018

@rodrigc Please, check also my PR if I missed it..

@refack refack self-assigned this Oct 14, 2018
@refack
Copy link
Contributor

refack commented Oct 14, 2018

@refack refack merged commit 63e6bc7 into nodejs:master Oct 14, 2018
@refack
Copy link
Contributor

refack commented Oct 14, 2018

@rodrigc Thank you very much!

refack pushed a commit that referenced this pull request Oct 14, 2018
refack pushed a commit that referenced this pull request Oct 14, 2018
* assertEquals() with assertEqual()
* iteritems() with items() for Python 3.
* xrange() with range() for Python 3.

#1150
Reviewed-By: Refael Ackermann <[email protected]>
refack pushed a commit that referenced this pull request Oct 14, 2018
@refack
Copy link
Contributor

refack commented Oct 14, 2018

Eventually landed as

73b5b63
3321444
9eb9b39
ef8b60a

rvagg pushed a commit that referenced this pull request Apr 24, 2019
rvagg pushed a commit that referenced this pull request Apr 24, 2019
* assertEquals() with assertEqual()
* iteritems() with items() for Python 3.
* xrange() with range() for Python 3.

#1150
Reviewed-By: Refael Ackermann <[email protected]>
rvagg pushed a commit that referenced this pull request Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants