Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win: improve parsing of SDK version #1516

Closed
wants to merge 1 commit into from
Closed

Conversation

Loghorn
Copy link
Contributor

@Loghorn Loghorn commented Jul 30, 2018

Checklist
Description of change

This makes the parsing more robust and fixes the additional issue
related to USB Device Connectivity component.

Fixes: #1144

@joaocgreis
Copy link
Member

cc @refack

@joaocgreis
Copy link
Member

This does not fix #1144 but rather #1466. The commit message will have to be changed, we can do it when landing.

@joaocgreis joaocgreis mentioned this pull request Aug 1, 2018
@maclover7
Copy link
Contributor

This makes the parsing more robust and fixes the additional issue
related to USB Device Connectivity component.

Fixes: nodejs#1466
@Loghorn
Copy link
Contributor Author

Loghorn commented Aug 2, 2018

@joaocgreis I've changed the commit message to point to the correct issue (#1466)

joaocgreis pushed a commit that referenced this pull request Aug 8, 2018
This makes the parsing more robust and fixes the additional issue
related to USB Device Connectivity component.

Fixes: #1466
PR-URL: #1516
Reviewed-By: João Reis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
joaocgreis pushed a commit that referenced this pull request Aug 8, 2018
This makes the parsing more robust and fixes the additional issue
related to USB Device Connectivity component.

Fixes: #1466
PR-URL: #1516
Reviewed-By: João Reis <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@joaocgreis
Copy link
Member

CI was green, additional run on v0.12 to check the backport to v3.x: https://ci.nodejs.org/job/nodegyp-test-commit/422/ (also green).

Landed in 25208f1 (master) and 340403c (v3.x).

Thanks @Loghorn!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

msbuild error MSB4025
5 participants