Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated compatibility code. #1670

Merged
merged 2 commits into from
May 6, 2019
Merged

Remove deprecated compatibility code. #1670

merged 2 commits into from
May 6, 2019

Conversation

bnoordhuis
Copy link
Member

  • Remove support for the IOJS_ORG_MIRROR, NVM_IOJS_ORG_MIRROR
    and NVM_NODEJS_ORG_MIRROR enviroment variables.

  • Remove obsolete support for io.js. It's been out of support
    for over three years now.

test/docker.sh Outdated
@@ -3,7 +3,6 @@
#set -e

test_node_versions="0.8.28 0.10.40 0.12.7 4.3.0 5.6.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be updating these (perhaps in a different PR) to in support versions of Node.js?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good idea. I could do that as a separate commit or a separate PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good idea. I could do that as a separate commit or a separate PR.

Your choice 😄

@bnoordhuis
Copy link
Member Author

bnoordhuis commented Mar 19, 2019

Updated after some delay... CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/116/ (edit: green!)

* Remove support for the IOJS_ORG_MIRROR, NVM_IOJS_ORG_MIRROR
  and NVM_NODEJS_ORG_MIRROR enviroment variables.

* Remove obsolete support for io.js. It's been out of support
  for over three years now.

PR-URL: #1670
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants