Update README.md #1802
Closed
Update README.md #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missing argument configure
rvagg
requested changes
Jun 29, 2019
| @@ -63,7 +63,7 @@ If you have multiple Python versions installed, you can identify which Python | |||
| version `node-gyp` uses by setting the `--python` variable: | |||
|
|
|||
| ``` bash | |||
| $ node-gyp --python /path/to/python2.7 | |||
| $ node-gyp configure --python /path/to/python2.7 | |||
There was a problem hiding this comment.
The option applies to more than just configure, but what you could do here is this:
``` $ node-gyp <command> --python /path/to/python2.7 ``` Where `<command>` is one of the [commands](#commands) listed below.
(I'm using pre tags to format this, don't use the raw markdown, use the rendered markdown, also the 'bash' type should be dropped here, it gets in the way of proper formatting)
There was a problem hiding this comment.
Also, this line uses /path/to/python2.7 but...
the example just a few lines below uses /path/to/executable/python2.7
This would be more readable it we used consistent paths in these two examples.
|
modified it myself and landed in ca990a1 |
rvagg
pushed a commit
that referenced
this pull request
Sep 26, 2019
(accepted with minor modifications by rvagg) PR-URL: #1802 Reviewed-By: Rod Vagg <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Sep 26, 2019
(accepted with minor modifications by rvagg) PR-URL: #1802 Reviewed-By: Rod Vagg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missing argument configure
Checklist
npm install && npm testpassesDescription of change