Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept Python 3 when NODE_GYP_PYTHON3 is defined #1815

Closed
wants to merge 5 commits into from
Closed

Accept Python 3 when NODE_GYP_PYTHON3 is defined #1815

wants to merge 5 commits into from

Commits on Jul 9, 2019

  1. python: move Python detection to its own file

    @joaocgreis
    joaocgreis committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    c79708d View commit details
    Browse the repository at this point in the history

  2. python: accept Python 3 when NODE_GYP_PYTHON3=1 

    This allows us to start testing Python 3 without breaking node-gyp
for users.

This also adds support for NODE_GYP_FORCE_PYTHON, which will be the
only Python binary acceptable when defined.
    @joaocgreis
    joaocgreis committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    e2c75b4 View commit details
    Browse the repository at this point in the history

  3. fixup: rename NODE_GYP_PYTHON3 to EXPERIMENTAL_NODE_GYP_PYTHON3

    @joaocgreis
    joaocgreis committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    cc6c659 View commit details
    Browse the repository at this point in the history

  4. fixup: reject outdated versions 3.0-3.4

    @joaocgreis
    joaocgreis committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    4617ecb View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2019

  1. fixup: fix linting

    @joaocgreis
    joaocgreis committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    19f02f6 View commit details
    Browse the repository at this point in the history