Decode stdout on Python 3 #1890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-github
approved these changes
Sep 25, 2019
richardlau
approved these changes
Sep 25, 2019
63 tasks
bnoordhuis
approved these changes
Sep 25, 2019
This was referenced Sep 25, 2019
rvagg
pushed a commit
that referenced
this pull request
Sep 26, 2019
PR-URL: #1890 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
|
landed in d90d9c5 |
rvagg
pushed a commit
that referenced
this pull request
Sep 26, 2019
PR-URL: #1890 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]>
This was referenced Sep 26, 2019
Closed
4 tasks
chrmoritz
added a commit
to chrmoritz/node
that referenced
this pull request
Nov 5, 2019
original commit: nodejs/node-gyp@19398a4 Refs: nodejs/node-gyp#1890 Co-Authored-By: Christian Clauss <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
Fixes #1849, #1854, #1861 https://github.com/nodejs/node-gyp/search?q=CLT&type=Issues
Python 2 does not make a distinction between bytes and str but Python 3 does. When we make calls to subprocess.Popen() on Python 3 we should stdout.decode("utf8") before performing string manipulations on it.
This modification also allows Accept Python 3 by default #1844 to pass all Travis CI tests.