Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src,win: allow 403 errors for arm64 node.lib #1934

Closed
wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

Checklist
  • npm install && npm test passes
  • tests are included
  • commit message follows commit guidelines
Description of change

The servers hosting the header packages for Electron return 403
instead of 404 for the constructed URL for arm64 node.lib for
older releases that do not support arm64.

Fixes: #1933

The servers hosting the header packages for Electron return 403
instead of 404 for the constructed URL for arm64 node.lib for
older releases that do not support arm64.
rvagg pushed a commit that referenced this pull request Oct 24, 2019
The servers hosting the header packages for Electron return 403
instead of 404 for the constructed URL for arm64 node.lib for
older releases that do not support arm64.

PR-URL: #1934
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: João Reis <[email protected]>
@rvagg
Copy link
Member

rvagg commented Oct 24, 2019

landed in e6aca7d

@ddombrowsky
Copy link

This bug caused a 4 hour headache yesterday. Thank you for the fix.
Here's some notes to hopefully bump this up in the search rank.
My problem was building diskusage using node-gyp as follows:

+ ../.bin/node-gyp rebuild --target=2.0.7 --arch=ia32 --dist-url=https://atom.io/download/electron
gyp info it worked if it ends with ok
gyp info using [email protected]
gyp info using [email protected] | win32 | ia32
gyp info find Python using Python version 2.7.14 found at "C:\Python27\python.exe"
gyp http GET https://atom.io/download/electron/v2.0.7/iojs-v2.0.7.tar.gz
gyp http 200 https://atom.io/download/electron/v2.0.7/iojs-v2.0.7.tar.gz
gyp http GET https://atom.io/download/electron/v2.0.7/SHASUMS256.txt
gyp http GET https://atom.io/download/electron/v2.0.7/win-x64/iojs.lib
gyp http GET https://atom.io/download/electron/v2.0.7/win-arm64/iojs.lib
gyp http GET https://atom.io/download/electron/v2.0.7/win-x86/iojs.lib
gyp http 403 https://atom.io/download/electron/v2.0.7/win-arm64/iojs.lib
gyp WARN install got an error, rolling back install
gyp http 200 https://atom.io/download/electron/v2.0.7/SHASUMS256.txt
gyp http 200 https://atom.io/download/electron/v2.0.7/win-x86/iojs.lib
gyp http 200 https://atom.io/download/electron/v2.0.7/win-x64/iojs.lib
gyp ERR! configure error
gyp ERR! stack Error: 403 status code downloading arm64 iojs.lib

rvagg pushed a commit that referenced this pull request Oct 27, 2019
The servers hosting the header packages for Electron return 403
instead of 404 for the constructed URL for arm64 node.lib for
older releases that do not support arm64.

PR-URL: #1934
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: João Reis <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 18, 2019
The servers hosting the header packages for Electron return 403
instead of 404 for the constructed URL for arm64 node.lib for
older releases that do not support arm64.

PR-URL: #1934
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: João Reis <[email protected]>
@Yashraj890
Copy link

Hello Team

I found one solution for this issue, just run the below command

npm install sqlite3 --build-from-source --runtime-electron --target-|YOUR ELECTRON VERSION| --dist-url=https://atom.io/download/electron

After running the above command, please run the - npm rebuild

Please let me know if anyone is able to resolve the issue with my solution.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node-gyp arm64 node.lib returns HTTP code 403
5 participants