Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: switch to GitHub Actions #2127

Closed
wants to merge 2 commits into from

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented May 13, 2020

Description of change

This PR switches test builds from Travis to GitHub Actions.

cc @rvagg @cclauss

Checklist

@codebytere codebytere force-pushed the swap-to-actions branch 9 times, most recently from 2d5d02b to 2f0cfca Compare May 13, 2020 21:23
@codebytere codebytere marked this pull request as ready for review May 13, 2020 21:29
@codebytere
Copy link
Member Author

Not 100% sure why the windows tests are failing 🤔 i copied pretty directly from the travis file.

@codebytere codebytere force-pushed the swap-to-actions branch 2 times, most recently from 2702bb3 to c27850c Compare May 13, 2020 21:32
@cclauss
Copy link
Contributor

cclauss commented May 13, 2020

Just use the same code that you use for the real operating systems. That should work.

@cclauss
Copy link
Contributor

cclauss commented May 13, 2020

On Windows you should be able to use python or maybe py or maybe py3 to get to Python 3.

.github/workflows/test.yml Outdated Show resolved Hide resolved
@cclauss
Copy link
Contributor

cclauss commented May 15, 2020

@codebytere codebytere force-pushed the swap-to-actions branch 5 times, most recently from 25e5a4c to 8ea1131 Compare May 15, 2020 19:37
uses: microsoft/[email protected]
- name: Install Dependencies
run: |
python -m pip install --upgrade pip flake8 pytest==4.6.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why hardcore pytest to a low version?

Copy link
Member Author

@codebytere codebytere May 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i pulled it from the python examples used in stock python GitHub Actions - I'll remove it.

@codebytere codebytere force-pushed the swap-to-actions branch 2 times, most recently from 702af88 to 8e0a956 Compare May 15, 2020 19:49
@codebytere codebytere force-pushed the swap-to-actions branch 2 times, most recently from 614b28f to 8aaf8b4 Compare May 15, 2020 19:57
fail-fast: false
matrix:
node: [10.x, 12.x, 14.x]
python: [2.7, 3.6, 3.7, 3.8]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove 2.7 since it's EOL

@rvagg rvagg closed this in d1176d7 Sep 9, 2020
rvagg pushed a commit that referenced this pull request Oct 14, 2020
Co-authored-by: Christian Clauss <[email protected]>
Co-authored-by: Matias Lopez <[email protected]>
PR-URL: #2210
Closes: #2127
Closes: #2209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants