chore: refactor the creation of config.gypi file #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
force-pushed
the
refactor-config-gypi-creation
branch
from
ccfbf13
to
78c4bd9
Compare
rvagg
approved these changes
Sep 8, 2021
|
good work @zcbenz, thanks for spending the time to do this, I look forward to your additional changes but you'll have to be patient with us (me mainly) due to bandwidth constraints |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
This PR refactors the
configure.jsfile to move the creation ofconfig.gypiinto a separatecreate-config-gypi.jsfile, as part of the refactoring I have also added a few tests. There should be no affects to users.Note that there is a small behavior change that the existence of
process.configis no longer tested, the property was added in Node.js v0.7.7 and node-gyp no longer runs on those ancient versions.This refactoring is preparation work to implement #2490.
/cc @rvagg