Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gyp): update gyp to v0.18.1 #3039

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Conversation

toyobayashi
Copy link
Contributor

@toyobayashi toyobayashi commented Jun 6, 2024

Checklist
Description of change
  • Update latest gyp to support wasm
Refs

#2974
nodejs/gyp-next#222
nodejs/gyp-next#240

@toyobayashi
Copy link
Contributor Author

#2974 (comment)

@legendecas wasm integration tests are added in this PR.

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind setting up python with 3.12 in https://github.com/nodejs/node-gyp/blob/main/.github/workflows/visual-studio.yml?

nodejs/gyp-next#222 uses the colon-equals syntax which is only supported since python 3.8. I think https://github.com/nodejs/node-gyp?tab=readme-ov-file#installation stated that the supported python version is 3.12.

@toyobayashi
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants