Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test/test-options when run through npm test. #755

Merged
merged 1 commit into from
Nov 19, 2015
Merged

Fix test/test-options when run through npm test. #755

merged 1 commit into from
Nov 19, 2015

Conversation

bnoordhuis
Copy link
Member

npm test dumps a ton of npm_config_* variables in the environment.
Remove those before starting the actual test.

R=@rvagg?

@bnoordhuis
Copy link
Member Author

Or R=@TooTallNate?

@bnoordhuis
Copy link
Member Author

@mhdawson Can you return the favor and review this PR?

@rvagg
Copy link
Member

rvagg commented Nov 18, 2015

lgtm @bnoordhuis, sorry for the delay, this is a good change

`npm test` dumps a ton of npm_config_* variables in the environment.
Remove those before starting the actual test.

PR-URL: #755
Reviewed-By: Rod Vagg <[email protected]>
@bnoordhuis bnoordhuis merged commit 0e2dfda into nodejs:master Nov 19, 2015
@bnoordhuis bnoordhuis deleted the fix-options-test branch November 19, 2015 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants