Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --cafile command line option. #837

Merged
merged 2 commits into from
Dec 10, 2015
Merged

Add --cafile command line option. #837

merged 2 commits into from
Dec 10, 2015
+281 −47

Commits on Dec 10, 2015

  1. Make download() function testable. 

    Move the function around so it can be tested and add a regression test.

As a policy vs. mechanism thing, change the control flow to handle
exceptions at the call site, not inside the download function.

PR-URL: #837
Reviewed-By: Rod Vagg <[email protected]>
    @bnoordhuis
    bnoordhuis committed Dec 10, 2015
    Configuration menu
    Copy the full SHA
    b3ad434 View commit details
    Browse the repository at this point in the history

  2. Add --cafile command line option. 

    Add an option for overriding the default CA chain that is used when
downloading the tarball.  This matches the npm option of the same
name and gets implicitly passed through the `npm_config_cafile`
environment variable.

Fixes: #695
PR-URL: #837
Reviewed-By: Rod Vagg <[email protected]>
    @bnoordhuis
    bnoordhuis committed Dec 10, 2015
    Configuration menu
    Copy the full SHA
    8c4b0ff View commit details
    Browse the repository at this point in the history