socket.setTimeout malfunction when timeout is string

[weihua44]

Test the following code,
node tst

telnet localhost 10015, the connection will be lost in 1 second
telnet locahost 10016 then telnet localhost 10015, the connection will not be lost (it means the timeout event is failed for some reason)
If you change the var "to" from string to int, the timeout will always working.

<<File: tst.js>>

var net = require('net');

var clilistener = net.createServer(function(c) {
    var to  = '1000';
//  var to  = 1000;
    var mark    = 'svr1:';
    console.log(mark+'cli connected from '+c.remoteAddress+':'+c.remotePort);
    console.log(mark+'set timeout to '+to);
    c.setTimeout(to, function() {
        console.log(mark+'time out arrived...');
        c.destroy();
    });
    c.on('error', function(err) {
        c.destroy();
    });
    c.on('close', function(isErr) {
        console.log(mark+'cli out');
    });
    //
});
clilistener.listen(10015);

var clilistener = net.createServer(function(c) {
    var to  = '60000';
//  var to  = 60000;
    var mark    = 'svr1:';
    console.log(mark+'cli connected from '+c.remoteAddress+':'+c.remotePort);
    console.log(mark+'set timeout to '+to);
    c.setTimeout(to, function() {
        console.log(mark+'time out arrived...');
        c.destroy();
    });
    c.on('error', function(err) {
        c.destroy();
    });
    c.on('close', function(isErr) {
        console.log(mark+'cli out');
    });
    //
});
clilistener.listen(10016);

[cjihrig]

@weihua44 are you able to try this commit - cjihrig/node@7f3261c? It seems to fix the problem on my end.

[weihua44]

@cjihrig Thanks, it works. And you taught me another way to change string to number ;-)

[trevnorris]

@cjihrig Is this something that should be merged?

[cjihrig]

@trevnorris there was some back and forth on the best way to fix bad timeout values. The most current fix for this is #8884

[trevnorris]

@cjihrig Thanks. Commented on that.

[cjihrig]

Closed in f347573