Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

http: fix assert on data/end after socket error #14087

Closed
wants to merge 1 commit into from
Closed

http: fix assert on data/end after socket error #14087

wants to merge 1 commit into from

Commits on Mar 25, 2015

  1. http: fix assert on data/end after socket error 

    This change is a backport of 1a3ca82
from io.js.

Original commit message:

  Read all pending data out of the socket on `error` event and ensure that
  no `data`/`end` handlers will be invoked on `socket.destroy()`.
  Otherwise following assertion happens:

      AssertionError: null == true
          at TLSSocket.socketOnData (_http_client.js:308:3)
          at TLSSocket.emit (events.js:107:17)
          at TLSSocket.Readable.read (_stream_readable.js:373:10)
          at TLSSocket.socketCloseListener (_http_client.js:229:10)
          at TLSSocket.emit (events.js:129:20)
          at TCP.close (net.js:476:12)

  Fix: nodejs#9348
  PR-URL: nodejs/node#1103
  Reviewed-By: Rod Vagg <[email protected]>
  Reviewed-By: Nicu Micleușanu <[email protected]>

Fixes nodejs#9348.
    @indutny
    indutny authored and Julien Gilli committed Mar 25, 2015
    Configuration menu
    Copy the full SHA
    d4b7135 View commit details
    Browse the repository at this point in the history