Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

V8 lateral 3.28 update #18206

Closed
wants to merge 6 commits into from
Closed

V8 lateral 3.28 update #18206

wants to merge 6 commits into from

Commits on Apr 28, 2015

  1. deps: update V8 to 3.28.71.19 

    The 3.28.73 update was technically unstable code. This reverts the code
to the latest 3.28 stable release.
    @trevnorris
    trevnorris authored and Julien Gilli committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    f6d63ca View commit details
    Browse the repository at this point in the history

  2. deps: apply floating irhydra patch to v8 

    Reviewed-By: Fedor Indutny <[email protected]>
PR-URL: nodejs#8476
    @trevnorris
    trevnorris authored and Julien Gilli committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    a89510e View commit details
    Browse the repository at this point in the history

  3. deps: fix postmortem-metadata generator in v8 

    Reviewed-By: Fedor Indutny <[email protected]>
PR-URL: nodejs#8476
    @refack
    refack authored and Julien Gilli committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    7468ec6 View commit details
    Browse the repository at this point in the history

  4. mdb_v8: fix dictionary properties access

    Dave Pacheco authored and Julien Gilli committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    f42c766 View commit details
    Browse the repository at this point in the history

  5. deps: backport use strict fix for V8 debugger 

    Backport 2ad2237507c5b5f9047b8d94d2f4997327eae852 from V8.

Original commit message:

  Fix Unhandled ReferenceError in debug-debugger.js

  This fixes following exception in Sky on attempt to set a breakpoint
  "Unhandled: Uncaught ReferenceError: break_point is not defined"
  I think this happens in Sky but not in Chrome because Sky scripts are executed in strict mode.

  BUG=None
  LOG=N
  [email protected]

  Review URL: https://codereview.chromium.org/741683002

  Cr-Commit-Position: refs/heads/master@{nodejs#25415}
    @yury-s
    yury-s authored and Julien Gilli committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    2fba7df View commit details
    Browse the repository at this point in the history

  6. build: fix build for SmartOS 

    This change in V8: https://code.google.com/p/v8/source/detail?r=22210
has introduced a method named OS::GetCurrentThreadId which fails to
compile on OSes where a "gettid" syscall does not exist.

This build issue has been fixed upstream by several changes:
- https://code.google.com/p/v8/source/detail?r=23459.
- https://codereview.chromium.org/649553002
- https://codereview.chromium.org/642223003

Another minor fix to the upstream changes was also necessary.
See https://code.google.com/p/v8/issues/detail?id=3620 for
more information.

The other build issue was due to the fact that alloca.h is not included
by other system includes on SmartOS, which is assumed by V8.

Built and tested on Linux, MacOS X, Windows and SmartOS.
    Julien Gilli committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    46dc37e View commit details
    Browse the repository at this point in the history