Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

deps: revert v8 Array.prototype.values() removal #25328

Closed
wants to merge 2 commits into from
Closed

deps: revert v8 Array.prototype.values() removal #25328

wants to merge 2 commits into from

Commits on May 15, 2015

  1. deps: revert v8 Array.prototype.values() removal 

    The Node 0.12 line was initially released with a version
of v8 that included Array.prototype.values(). In
#18206, v8 was
updated to a version that dropped support for values().
https://codereview.chromium.org/647703003 removed this
method because it causes problems with some versions of
Outlook Web Access. This commit reverts the removal of
Array.prototype.values().

Original commit message:

Revert "Version 3.28.71.17 (merged r24706, r24708)"

This reverts commit 529541ecb58fd0d6df4dfbe41d01bff9ae21ff06.

Conflicts:
	src/version.cc
    @cjihrig
    cjihrig committed May 15, 2015
    Configuration menu
    Copy the full SHA
    4a123c1 View commit details
    Browse the repository at this point in the history

  2. test: Array.prototype.values() regression test 

    This commit adds a regression test for
#25324
    @cjihrig
    cjihrig committed May 15, 2015
    Configuration menu
    Copy the full SHA
    f8c05f6 View commit details
    Browse the repository at this point in the history