Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

build: don't use "-Wnewline-eof" on OS X #3887

Closed
wants to merge 1 commit into from
Closed

build: don't use "-Wnewline-eof" on OS X #3887

wants to merge 1 commit into from

Conversation

TooTallNate
Copy link

This is the only thing preventing a manually compiled version of GCC (rather than Apple's provided llvm-gcc or gcc 4.2) from working properly, so we might as well enable support for that.

With this patch I was able to compile node using a manually compiled gcc 4.7.1.

@isaacs @bnoordhuis Any objections?

This is the only thing preventing a manually compiled version of GCC
(rather than Apple's provided llvm-gcc or heavily modified gcc 4.2)
from working properly, so we might as well enable support for that.

With this patch I was able to compile node using a manually compiled
gcc 4.7.1.
@bnoordhuis
Copy link
Member

LGTM

richardlau pushed a commit to ibmruntimes/node that referenced this pull request Dec 17, 2015
Fix node exiting due to an exception being thrown rather than emitting
an 'uncaughtException' event on the process object when:
1. no error handler is set on the domain within which an error is thrown
2. an 'uncaughtException' event listener is set on the process

Also fix an issue where the process would not abort in the proper
function call if an error is thrown within a domain with no error
handler and --abort-on-uncaught-exception is used.

Fixes nodejs#3607 and nodejs#3653.

PR: nodejs#3887
PR-URL: nodejs/node#3887
Reviewed-By: James M Snell <[email protected]>
richardlau pushed a commit to ibmruntimes/node that referenced this pull request Feb 15, 2016
Fix node exiting due to an exception being thrown rather than emitting
an 'uncaughtException' event on the process object when:
1. no error handler is set on the domain within which an error is thrown
2. an 'uncaughtException' event listener is set on the process

Also fix an issue where the process would not abort in the proper
function call if an error is thrown within a domain with no error
handler and --abort-on-uncaught-exception is used.

Fixes nodejs#3607 and nodejs#3653.

PR: nodejs#3887
PR-URL: nodejs/node#3887
Reviewed-By: James M Snell <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants