This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
build: don't use "-Wnewline-eof" on OS X #3887
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only thing preventing a manually compiled version of GCC (rather than Apple's provided llvm-gcc or gcc 4.2) from working properly, so we might as well enable support for that.
With this patch I was able to compile node using a manually compiled gcc 4.7.1.
@isaacs @bnoordhuis Any objections?