This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Commits on Mar 17, 2015
-
Configuration menu - View commit details
-
Copy full SHA for a91bef9 - Browse repository at this point
Copy the full SHA a91bef9View commit details -
build: fix use of strict aliasing
The -fno-strict-aliasing flag was added to fix compilation warnings when building Node.js with GCC <= 4.4
Configuration menu - View commit details
-
Copy full SHA for 8d53bec - Browse repository at this point
Copy the full SHA 8d53becView commit details -
lib: fix stdio/ipc sync i/o regression
process.send() should be synchronous, it should block until the message has been sent in full, but it wasn't after the second-to-last libuv upgrade because of commit libuv/libuv@393c1c5 ("unix: set non-block mode in uv_{pipe,tcp,udp}_open"), which made its way into io.js in commit 07bd05b ("deps: update libuv to 1.2.1"). Commit libuv/libuv@b36d4ff ("unix: implement uv_stream_set_blocking()") as landed in io.js in commit 9681fca ("deps: update libuv to 1.4.0") makes it possible to restore the synchronous behavior again and that's precisely what this commit does. The same line of reasoning applies to `net.Socket({ fd: 1 })`: creating a socket object from a stdio file descriptor, like the `process.stdout` getter does, should put the file descriptor in blocking mode for compatibility reasons. PR-URL: nodejs/node#774 Reviewed-by: Trevor Norris <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 201a706 - Browse repository at this point
Copy the full SHA 201a706View commit details -
Float patch to fix pipe on Windows. Original commit message: win: fix pipe blocking writes In the code path for pipe blocking writes, WriteFile is already posting a completion packet to the I/O completion port. POST_COMPLETION_FOR_REQ was causing the same request to get returned twice by GetCompletionStatusEx. Also on the same code path, we were waiting on the wrong event. We need to update queued_bytes and write_queue_size when a blocking write request completes asynchronously. Ref: libuv/libuv#238
Configuration menu - View commit details
-
Copy full SHA for 6403576 - Browse repository at this point
Copy the full SHA 6403576View commit details -
uv: fix setsockopt for multicast options
Float patch to fix setsockopt for multicast on Solaris and derivatives. Original commit message: solaris: fix setsockopt for multicast options On Solaris and derivatives such as SmartOS, the length of socket options for multicast and ttl options is not always sizeof(char). This fixes the udp_options and udp_options6 tests. Ref: libuv/libuv#243
Configuration menu - View commit details
-
Copy full SHA for cdc929b - Browse repository at this point
Copy the full SHA cdc929bView commit details -
uv: fix size calculation in select() fallback
Original commit message: darwin: fix size calculation in select() fallback Apple's `fd_set` stores its bits in an array of 32-bit integers, which means `FD_ISSET()` may read out of bounds if we allocate storage at byte granularity. There's also a chance that the `select()` call could corrupt the heap, although I didn't investigate that. This issue was discovered by LLVM's AddressSanitizer which caught `FD_ISSET()` trying to read out of bounds. Ref: libuv/libuv#241
Configuration menu - View commit details
-
Copy full SHA for 177aa42 - Browse repository at this point
Copy the full SHA 177aa42View commit details
Commits on Mar 18, 2015
-
deps: indicate uv has been patched
Because we are floating several patches on top of libuv, make that apparent in the version number.
Configuration menu - View commit details
-
Copy full SHA for c515187 - Browse repository at this point
Copy the full SHA c515187View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.