test: update postmortem metadata test #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 6.5. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
It is necessary to enable more C++ features in order to build V8 6.4.
This commit renames V8DBG_CLASS_MAP__INSTANCE_ATTRIBUTES__INT to V8DBG_CLASS_MAP__INSTANCE_TYPE__UINT16_T following upstream changes.
This commit updates the following postmortem metadata constants:
- v8dbg_class_Map__inobject_properties_or_constructor_function_index__int
- This is now
v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char
as of
v8/v8@61bf2cc
- v8dbg_class_Map__instance_attributes__int
- This is now v8dbg_class_Map__instance_type__uint16_t as of
v8/v8@c00bb6d
and
v8/v8@cb46310
- v8dbg_class_Map__instance_size__int
- This is now v8dbg_class_Map__instance_size_in_words__char as of
v8/v8@61bf2cc
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
This was referenced Dec 19, 2017
|
Thanks! Quick check: https://ci.nodejs.org/job/node-test-commit-light/41/ |
|
There was a failure in the CI, but unrelated. |
bnoordhuis
approved these changes
Dec 19, 2017
joyeecheung
approved these changes
Dec 20, 2017
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Dec 20, 2017
This commit updates the following postmortem metadata constants:
- v8dbg_class_Map__inobject_properties_or_constructor_function_index__int
- This is now
v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char
as of
v8/v8@61bf2cc
- v8dbg_class_Map__instance_attributes__int
- This is now v8dbg_class_Map__instance_type__uint16_t as of
v8/v8@c00bb6d
and
v8/v8@cb46310
- v8dbg_class_Map__instance_size__int
- This is now v8dbg_class_Map__instance_size_in_words__char as of
v8/v8@61bf2cc
Refs: nodejs/node-v8#34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Dec 20, 2017
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: nodejs/node-v8#34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
|
Thanks, landed in nodejs/node@358a628 and nodejs/node@034b64b. |
I'm inclined to say no, simply because wikis get forgotten about and out of sync. I'm hoping to achieve the same thing in the commit log for the metadata test moving forward though. |
nodejs-ci
pushed a commit
that referenced
this pull request
Dec 21, 2017
This commit updates the following postmortem metadata constants:
- v8dbg_class_Map__inobject_properties_or_constructor_function_index__int
- This is now
v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char
as of
v8/v8@61bf2cc
- v8dbg_class_Map__instance_attributes__int
- This is now v8dbg_class_Map__instance_type__uint16_t as of
v8/v8@c00bb6d
and
v8/v8@cb46310
- v8dbg_class_Map__instance_size__int
- This is now v8dbg_class_Map__instance_size_in_words__char as of
v8/v8@61bf2cc
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Dec 21, 2017
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Dec 22, 2017
This commit updates the following postmortem metadata constants:
- v8dbg_class_Map__inobject_properties_or_constructor_function_index__int
- This is now
v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char
as of
v8/v8@61bf2cc
- v8dbg_class_Map__instance_attributes__int
- This is now v8dbg_class_Map__instance_type__uint16_t as of
v8/v8@c00bb6d
and
v8/v8@cb46310
- v8dbg_class_Map__instance_size__int
- This is now v8dbg_class_Map__instance_size_in_words__char as of
v8/v8@61bf2cc
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Dec 22, 2017
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Dec 23, 2017
This commit updates the following postmortem metadata constants:
- v8dbg_class_Map__inobject_properties_or_constructor_function_index__int
- This is now
v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char
as of
v8/v8@61bf2cc
- v8dbg_class_Map__instance_attributes__int
- This is now v8dbg_class_Map__instance_type__uint16_t as of
v8/v8@c00bb6d
and
v8/v8@cb46310
- v8dbg_class_Map__instance_size__int
- This is now v8dbg_class_Map__instance_size_in_words__char as of
v8/v8@61bf2cc
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Dec 23, 2017
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Feb 14, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Feb 15, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Feb 16, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Feb 17, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Feb 18, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Feb 18, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Feb 19, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Feb 20, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Feb 21, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Feb 21, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Feb 22, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Feb 23, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Feb 24, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Feb 25, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Feb 26, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Feb 27, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Feb 28, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Mar 1, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Mar 2, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Mar 3, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Mar 4, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Mar 5, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Mar 6, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
nodejs-ci
pushed a commit
that referenced
this pull request
Mar 7, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: #34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 7, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: nodejs/node-v8#34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Mar 7, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: nodejs/node-v8#34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #18453
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yang Guo <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
This commit updates the following postmortem metadata constants:
- v8dbg_class_Map__inobject_properties_or_constructor_function_index__int
- This is now
v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char
as of
v8/v8@61bf2cc
- v8dbg_class_Map__instance_attributes__int
- This is now v8dbg_class_Map__instance_type__uint16_t as of
v8/v8@c00bb6d
and
v8/v8@cb46310
- v8dbg_class_Map__instance_size__int
- This is now v8dbg_class_Map__instance_size_in_words__char as of
v8/v8@61bf2cc
Refs: nodejs/node-v8#34
PR-URL: nodejs#17489
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
This commit updates the following postmortem metadata constant:
- v8dbg_bit_field3_dictionary_map_shift
- This is now v8dbg_bit_field3_is_dictionary_map_shift as of
v8/v8@7a159da
Refs: nodejs/node-v8#34
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: nodejs#18453
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yang Guo <[email protected]>
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the following postmortem metadata constants:
v8dbg_class_Map__inobject_properties_or_constructor_function_index__intv8dbg_class_Map__inobject_properties_start_or_constructor_function_index__charas of v8/v8@61bf2ccv8dbg_class_Map__instance_attributes__intv8dbg_class_Map__instance_type__uint16_tas of v8/v8@c00bb6d and v8/v8@cb46310v8dbg_class_Map__instance_size__intv8dbg_class_Map__instance_size_in_words__charas of v8/v8@61bf2ccv8dbg_bit_field3_dictionary_map_shiftv8dbg_bit_field3_is_dictionary_map_shiftas of v8/v8@7a159daFixes: #33
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)