Skip to content

Commit

Permalink
test: improve tests for util.inherits
Browse files Browse the repository at this point in the history
inherits is used in lib and tests but its functionality itself is not
tested yet.

PR-URL: #3507
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
  • Loading branch information
targos authored and jasnell committed Oct 28, 2015
1 parent 9e05af7 commit 12d8385
Show file tree
Hide file tree
Showing 2 changed files with 46 additions and 7 deletions.
46 changes: 46 additions & 0 deletions test/parallel/test-util-inherits.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
'use strict';

require('../common');
const assert = require('assert');
const inherits = require('util').inherits;

// super constructor
function A() {
this._a = 'a';
}
A.prototype.a = function() { return this._a; };

// one level of inheritance
function B(value) {
A.call(this);
this._b = value;
}
inherits(B, A);
B.prototype.b = function() { return this._b; };

assert.strictEqual(B.super_, A);

const b = new B('b');
assert.strictEqual(b.a(), 'a');
assert.strictEqual(b.b(), 'b');
assert.strictEqual(b.constructor, B);

// two levels of inheritance
function C() {
B.call(this, 'b');
this._c = 'c';
}
inherits(C, B);
C.prototype.c = function() { return this._c; };
C.prototype.getValue = function() { return this.a() + this.b() + this.c(); };

assert.strictEqual(C.super_, B);

const c = new C();
assert.strictEqual(c.getValue(), 'abc');
assert.strictEqual(c.constructor, C);

// should throw with invalid arguments
assert.throws(function() { inherits(A, {}); }, TypeError);
assert.throws(function() { inherits(A, null); }, TypeError);
assert.throws(function() { inherits(null, A); }, TypeError);
7 changes: 0 additions & 7 deletions test/parallel/test-util.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,3 @@ assert.deepEqual(util._extend({a:1}, true), {a:1});
assert.deepEqual(util._extend({a:1}, false), {a:1});
assert.deepEqual(util._extend({a:1}, {b:2}), {a:1, b:2});
assert.deepEqual(util._extend({a:1, b:2}, {b:3}), {a:1, b:3});

// inherits
var ctor = function() {};
assert.throws(function() { util.inherits(ctor, {}); }, TypeError);
assert.throws(function() { util.inherits(ctor, null); }, TypeError);
assert.throws(function() { util.inherits(null, ctor); }, TypeError);
assert.doesNotThrow(function() { util.inherits(ctor, ctor); }, TypeError);

0 comments on commit 12d8385

Please sign in to comment.