Skip to content

Commit

Permalink
tools: improve update scripts
Browse files Browse the repository at this point in the history
The --production flag has no effect in this situation. Remove it.

Add --ignore-scripts as a precaution.

PR-URL: #40644
Reviewed-By: Antoine du Hamel <[email protected]>
  • Loading branch information
Trott authored and danielleadams committed Jan 30, 2022
1 parent 786ce2c commit 157d600
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tools/update-babel-eslint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ ROOT="$PWD/../.."
NPM="$ROOT/deps/npm/bin/npm-cli.js"

"$NODE" "$NPM" init --yes
"$NODE" "$NPM" install --global-style --no-bin-links --production --no-package-lock @babel/core @babel/eslint-parser@latest @babel/plugin-syntax-import-assertions@latest
"$NODE" "$NPM" install --global-style --no-bin-links --ignore-scripts --no-package-lock @babel/core @babel/eslint-parser @babel/plugin-syntax-import-assertions

# Use dmn to remove some unneeded files.
"$NODE" "$NPM" exec -- [email protected] -f clean
Expand Down
3 changes: 1 addition & 2 deletions tools/update-eslint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ rm -rf node_modules/eslint node_modules/eslint-plugin-markdown

"$NODE" "$NPM" init --yes

"$NODE" "$NPM" install --global-style --no-bin-links --production --no-package-lock eslint@latest
"$NODE" "$NPM" install --global-style --no-bin-links --production --no-package-lock eslint-plugin-markdown@latest
"$NODE" "$NPM" install --global-style --no-bin-links --ignore-scripts --no-package-lock eslint eslint-plugin-markdown

# Use dmn to remove some unneeded files.
"$NODE" "$NPM" exec -- [email protected] -f clean
Expand Down

0 comments on commit 157d600

Please sign in to comment.