test: refactor test-tls-env-extra-ca

* Use `common.mustCall()` to guarantee callback invocations * Order modules according to test writing guide PR-URL: #13886 Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
nodejs · Aug 15, 2017 · 16998a1 · 16998a1
1 parent 73ba423
commit 16998a1
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/test/parallel/test-tls-env-extra-ca.js b/test/parallel/test-tls-env-extra-ca.js
@@ -9,18 +9,19 @@ if (!common.hasCrypto) {
 }
 
 const assert = require('assert');
+const fs = require('fs');
 const tls = require('tls');
+
 const fork = require('child_process').fork;
-const fs = require('fs');
 
 if (process.env.CHILD) {
   const copts = {
     port: process.env.PORT,
-    checkServerIdentity: common.noop,
+    checkServerIdentity: common.mustCall(),
   };
-  const client = tls.connect(copts, function() {
+  const client = tls.connect(copts, common.mustCall(function() {
     client.end('hi');
-  });
+  }));
   return;
 }
 
@@ -29,10 +30,10 @@ const options = {
   cert: fs.readFileSync(`${common.fixturesDir}/keys/agent1-cert.pem`),
 };
 
-const server = tls.createServer(options, function(s) {
+const server = tls.createServer(options, common.mustCall(function(s) {
   s.end('bye');
   server.close();
-}).listen(0, common.mustCall(function() {
+})).listen(0, common.mustCall(function() {
   const env = {
     CHILD: 'yes',
     PORT: this.address().port,