deps: silence irrelevant V8 warnings

PR-URL: #25852 Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
nodejs · Mar 14, 2019 · 1c494b0 · 1c494b0
1 parent ff5d632
commit 1c494b0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/deps/v8/gypfiles/toolchain.gypi b/deps/v8/gypfiles/toolchain.gypi
@@ -1393,7 +1393,7 @@
         ],  # conditions
       },  # Release
     },  # configurations
-    'cflags': [ '-Wno-type-limits', ],
+    'cflags!': [ '-Wall', '-Wextra' ],
     'msvs_disabled_warnings': [
       4245,  # Conversion with signed/unsigned mismatch.
       4267,  # Conversion with possible loss of data.

diff --git a/deps/v8/include/v8.h b/deps/v8/include/v8.h
@@ -4337,14 +4337,13 @@ class V8_EXPORT CompiledWasmModule {
 class V8_EXPORT WasmModuleObject : public Object {
  public:
   // TODO(clemensh): Remove after 7.3 branch.
-  V8_DEPRECATED("Use OwnedBuffer", typedef)
-  std::pair<std::unique_ptr<const uint8_t[]>, size_t> SerializedModule;
+  typedef std::pair<std::unique_ptr<const uint8_t[]>, size_t> SerializedModule;
 
   /**
    * A unowned reference to a byte buffer.
    * TODO(clemensh): Remove after 7.3 branch.
    */
-  V8_DEPRECATED("Use MemorySpan<const uint8_t>", struct) BufferReference {
+  struct BufferReference {
     const uint8_t* start;
     size_t size;
     BufferReference(const uint8_t* start, size_t size)