errors: alter ERR_INVALID_IP_ADDRESS

changes the base instance for ERR_INVALID_IP_ADDRESS from Error to TypeError as a more accurate representation of the error. PR-URL: #19979 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
nodejs · Apr 14, 2018 · 2119cee · 2119cee
1 parent 985d180
commit 2119cee
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/lib/dns.js b/lib/dns.js
@@ -316,7 +316,7 @@ function setServers(servers) {
       return newSet.push([ipVersion, s, parseInt(p)]);
     }
 
-    throw new ERR_INVALID_IP_ADDRESS.Error(serv);
+    throw new ERR_INVALID_IP_ADDRESS(serv);
   });
 
   const errorNumber = this._handle.setServers(newSet);

diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -891,8 +891,7 @@ E('ERR_INVALID_FILE_URL_HOST',
 E('ERR_INVALID_FILE_URL_PATH', 'File URL path %s', TypeError);
 E('ERR_INVALID_HANDLE_TYPE', 'This handle type cannot be sent', TypeError);
 E('ERR_INVALID_HTTP_TOKEN', '%s must be a valid HTTP token ["%s"]', TypeError);
-// The `Error` should probably be a `TypeError`.
-E('ERR_INVALID_IP_ADDRESS', 'Invalid IP address: %s', TypeError, Error);
+E('ERR_INVALID_IP_ADDRESS', 'Invalid IP address: %s', TypeError);
 E('ERR_INVALID_OPT_VALUE', (name, value) =>
   `The value "${String(value)}" is invalid for option "${name}"`,
   TypeError,

diff --git a/test/parallel/test-dns.js b/test/parallel/test-dns.js
@@ -70,12 +70,12 @@ dns.setServers(goog);
 assert.deepStrictEqual(dns.getServers(), goog);
 common.expectsError(() => dns.setServers(['foobar']), {
   code: 'ERR_INVALID_IP_ADDRESS',
-  type: Error,
+  type: TypeError,
   message: 'Invalid IP address: foobar'
 });
 common.expectsError(() => dns.setServers(['127.0.0.1:va']), {
   code: 'ERR_INVALID_IP_ADDRESS',
-  type: Error,
+  type: TypeError,
   message: 'Invalid IP address: 127.0.0.1:va'
 });
 assert.deepStrictEqual(dns.getServers(), goog);