Skip to content

Commit

Permalink
src: deprecate UVException() without Isolate*
Browse files Browse the repository at this point in the history
This method, like all other methods which use `Isolate::GetCurrent()`,
should be avoided.

This was probably overlooked in 75adde0.

PR-URL: #23175
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
  • Loading branch information
addaleax authored and targos committed Oct 4, 2018
1 parent e9a0cff commit 2da6f62
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/node.h
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,8 @@ NODE_DEPRECATED("Use ErrnoException(isolate, ...)",
path);
})

inline v8::Local<v8::Value> UVException(int errorno,
NODE_DEPRECATED("Use UVException(isolate, ...)",
inline v8::Local<v8::Value> UVException(int errorno,
const char* syscall = nullptr,
const char* message = nullptr,
const char* path = nullptr) {
Expand All @@ -148,7 +149,7 @@ inline v8::Local<v8::Value> UVException(int errorno,
syscall,
message,
path);
}
})

/*
* These methods need to be called in a HandleScope.
Expand Down

0 comments on commit 2da6f62

Please sign in to comment.