Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: deprecate UVException() without Isolate* #23175

Conversation

addaleax
Copy link
Member

This method, like all other methods which use Isolate::GetCurrent(), should be avoided.

This was probably overlooked in 75adde0.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

This method, like all other methods which use `Isolate::GetCurrent()`,
should be avoided.

This was probably overlooked in 75adde0.
@addaleax addaleax added c++ Issues and PRs that require attention from people who are familiar with C++. semver-minor PRs that contain new features and should be released in the next minor version. addons Issues and PRs related to native addons. labels Sep 30, 2018
@addaleax addaleax added the deprecations Issues and PRs related to deprecations. label Sep 30, 2018
@addaleax
Copy link
Member Author

addaleax commented Oct 3, 2018

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 3, 2018
@danbev
Copy link
Contributor

danbev commented Oct 4, 2018

Landed in c3aaaa7.

@danbev danbev closed this Oct 4, 2018
danbev pushed a commit that referenced this pull request Oct 4, 2018
This method, like all other methods which use `Isolate::GetCurrent()`,
should be avoided.

This was probably overlooked in 75adde0.

PR-URL: #23175
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit that referenced this pull request Oct 4, 2018
This method, like all other methods which use `Isolate::GetCurrent()`,
should be avoided.

This was probably overlooked in 75adde0.

PR-URL: #23175
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
This method, like all other methods which use `Isolate::GetCurrent()`,
should be avoided.

This was probably overlooked in 75adde0.

PR-URL: #23175
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@addaleax addaleax deleted the deprecate-uv-exception-without-isolate branch May 19, 2019 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. deprecations Issues and PRs related to deprecations. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants