fs: refactor rimraf to avoid using primordials

PR-URL: #54834 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Sep 13, 2024 · 375cbb5 · 375cbb5
1 parent 31d4ef9
commit 375cbb5
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/internal/fs/rimraf.js b/lib/internal/fs/rimraf.js
@@ -139,8 +139,10 @@ function _rmchildren(path, options, callback) {
 
     let done = false;
 
-    ArrayPrototypeForEach(files, (child) => {
-      const childPath = Buffer.concat([pathBuf, separator, child]);
+    const childPathPrefix = Buffer.concat([pathBuf, separator]);
+
+    for (let i = 0; i < files.length; i++) {
+      const childPath = Buffer.concat([childPathPrefix, files[i]]);
 
       rimraf(childPath, options, (err) => {
         if (done)
@@ -155,7 +157,7 @@ function _rmchildren(path, options, callback) {
         if (numFiles === 0)
           rmdir(path, callback);
       });
-    });
+    }
   });
 }