Skip to content

Commit

Permalink
test: pass python path to node-gyp
Browse files Browse the repository at this point in the history
node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.

PR-URL: #6646
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
  • Loading branch information
hefangshi authored and evanlucas committed May 17, 2016
1 parent 0c62bd1 commit 3f9d724
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ test-valgrind: all

test/gc/node_modules/weak/build/Release/weakref.node: $(NODE_EXE)
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
--python="$(PYTHON)" \
--directory="$(shell pwd)/test/gc/node_modules/weak" \
--nodedir="$(shell pwd)"

Expand All @@ -151,6 +152,7 @@ test/addons/.buildstamp: $(ADDONS_BINDING_GYPS) \
# embedded addons have been generated from the documentation.
for dirname in test/addons/*/; do \
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
--python="$(PYTHON)" \
--directory="$$PWD/$$dirname" \
--nodedir="$$PWD" || exit 1 ; \
done
Expand Down

0 comments on commit 3f9d724

Please sign in to comment.