inspector: send messages after the Node is done

Fixes: #14432 PR-URL: #14463 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Jul 27, 2017 · 4836f3b · 4836f3b
1 parent 0ff19b0
commit 4836f3b
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/src/inspector_io.cc b/src/inspector_io.cc
@@ -429,8 +429,6 @@ void InspectorIo::MainThreadReqAsyncCb(uv_async_t* req) {
 
 void InspectorIo::Write(TransportAction action, int session_id,
                         const StringView& inspector_message) {
-  if (state_ == State::kShutDown)
-    return;
   AppendMessage(&outgoing_message_queue_, action, session_id,
                 StringBuffer::create(inspector_message));
   int err = uv_async_send(&thread_req_);

diff --git a/test/inspector/test-inspector-stop-profile-after-done.js b/test/inspector/test-inspector-stop-profile-after-done.js
@@ -0,0 +1,21 @@
+'use strict';
+const common = require('../common');
+common.skipIfInspectorDisabled();
+const helper = require('./inspector-helper.js');
+
+function test(session) {
+  session.sendInspectorCommands([
+    { 'method': 'Runtime.runIfWaitingForDebugger' },
+    { 'method': 'Profiler.setSamplingInterval', 'params': { 'interval': 100 } },
+    { 'method': 'Profiler.enable' },
+    { 'method': 'Profiler.start' }]);
+  session.expectStderrOutput('Waiting for the debugger to disconnect...');
+  session.sendInspectorCommands({ 'method': 'Profiler.stop' });
+  session.disconnect(true);
+}
+
+function runTests(harness) {
+  harness.runFrontendSession([test]).expectShutDown(0);
+}
+
+helper.startNodeForInspectorTest(runTests, ['--inspect-brk'], 'let a = 2;');