Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector: send messages after the Node is done #14463

Merged
merged 0 commits into from
Jul 26, 2017
Merged

inspector: send messages after the Node is done #14463

merged 0 commits into from
Jul 26, 2017

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Jul 24, 2017

Fixes: #14432

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

inspector: removed one condition that was added as a "sanity check"

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x inspector Issues and PRs related to the V8 inspector protocol labels Jul 24, 2017
@eugeneo
Copy link
Contributor Author

eugeneo commented Jul 26, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9360/

@eugeneo eugeneo closed this Jul 26, 2017
@eugeneo eugeneo deleted the fix_profiler branch July 26, 2017 19:16
@eugeneo
Copy link
Contributor Author

eugeneo commented Jul 26, 2017

Landed as bd65767

@eugeneo eugeneo merged commit bd65767 into nodejs:master Jul 26, 2017
@vsemozhetbyt
Copy link
Contributor

FWIW, we have two windows failures due to inspector/test-inspector-stop-profile-after-done in #14506 (CI: https://ci.nodejs.org/job/node-test-pull-request/9368/)

addaleax pushed a commit that referenced this pull request Jul 27, 2017
@addaleax
inspector: send messages after the Node is done
4836f3b 
Fixes: #14432
PR-URL: #14463
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax addaleax mentioned this pull request Aug 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inspector profiling can't be stopped or viewed after script finishes running
6 participants
@eugeneo @vsemozhetbyt @jasnell @cjihrig @MylesBorins @nodejs-github-bot