napi: supress invalid coverity leak message

Coverity was complaining that finalizer was being leaked in this method, however it should be freed when the buffer is finalized so I believe the message is invalid. Add the required comments to suppress the warning. PR-URL: #12192 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Hitesh Kanwathirtha <[email protected]>
nodejs · Apr 5, 2017 · 491d59d · 491d59d
1 parent 4a21e39
commit 491d59d
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/node_api.cc b/src/node_api.cc
@@ -2290,6 +2290,10 @@ napi_status napi_create_external_buffer(napi_env env,
 
   *result = v8impl::JsValueFromV8LocalValue(maybe.ToLocalChecked());
   return GET_RETURN_STATUS();
+  // Tell coverity that 'finalizer' should not be freed when we return
+  // as it will be deleted when the buffer to which it is associated
+  // is finalized.
+  // coverity[leaked_storage]
 }
 
 napi_status napi_create_buffer_copy(napi_env env,