report: fix build warning in node_report.cc

Fixes `maybe-uninitialized` build warning in `src/node_report.cc`. PR-URL: #26265 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs · Feb 28, 2019 · 4a10ce6 · 4a10ce6
1 parent cd302d7
commit 4a10ce6
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/node_report.cc b/src/node_report.cc
@@ -172,16 +172,14 @@ std::string TriggerNodeReport(Isolate* isolate,
       std::cerr << " (errno: " << errno << ")" << std::endl;
       return "";
     }
+    outstream = &outfile;
 
     std::cerr << std::endl
               << "Writing Node.js report to file: " << filename << std::endl;
   }
 
-  // Pass our stream about by reference, not by copying it.
-  std::ostream& out = outfile.is_open() ? outfile : *outstream;
-
-  WriteNodeReport(
-      isolate, env, message, location, filename, out, stackstr, &tm_struct);
+  WriteNodeReport(isolate, env, message, location, filename, *outstream,
+                  stackstr, &tm_struct);
 
   // Do not close stdout/stderr, only close files we opened.
   if (outfile.is_open()) {