lib: runtime deprecate punycode

PR-URL: #47202 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
nodejs · Apr 3, 2023 · 4b08c4c · 4b08c4c
1 parent 74b9cf2
commit 4b08c4c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
@@ -872,6 +872,9 @@ The [`require.extensions`][] property is deprecated.
 
 <!-- YAML
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/47202
+    description: Runtime deprecation.
   - version: v16.6.0
     pr-url: https://github.com/nodejs/node/pull/38444
     description: Added support for `--pending-deprecation`.
@@ -880,7 +883,7 @@ changes:
     description: Documentation-only deprecation.
 -->
 
-Type: Documentation-only (supports [`--pending-deprecation`][])
+Type: Runtime
 
 The [`punycode`][] module is deprecated. Please use a userland alternative
 instead.

diff --git a/lib/punycode.js b/lib/punycode.js
@@ -1,14 +1,11 @@
 'use strict';
 
-const { getOptionValue } = require('internal/options');
-if (getOptionValue('--pending-deprecation')){
-	process.emitWarning(
-		'The `punycode` module is deprecated. Please use a userland ' +
-		'alternative instead.',
-		'DeprecationWarning',
-		'DEP0040',
-	);
-}
+process.emitWarning(
+  'The `punycode` module is deprecated. Please use a userland ' +
+  'alternative instead.',
+  'DeprecationWarning',
+  'DEP0040',
+);
 
 /** Highest positive signed 32-bit float value */
 const maxInt = 2147483647; // aka. 0x7FFFFFFF or 2^31-1

diff --git a/test/message/core_line_numbers.out b/test/message/core_line_numbers.out
@@ -1,9 +1,9 @@
-node:punycode:52
+node:punycode:49
 	throw new RangeError(errors[type]);
 	^
 
 RangeError: Invalid input
-    at error (node:punycode:52:8)
+    at error (node:punycode:49:8)
     at Object.decode (node:punycode:*:*)
     at Object.<anonymous> (*test*message*core_line_numbers.js:*:*)