-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tls: fix session and keylog add listener segfault
Fix an issue where adding a session or keylog listener on a tlsSocket after it was destroyed caused a segfault. fixes: #38133 fixes: #38135
- Loading branch information
Showing
2 changed files
with
30 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
if (!common.hasCrypto) | ||
common.skip('missing crypto'); | ||
|
||
// This test ensures that Node.js doesn't incur a segfault while | ||
// adding session or keylog listeners after destroy. | ||
// https://github.com/nodejs/node/issues/38133 | ||
// https://github.com/nodejs/node/issues/38135 | ||
|
||
const tls = require('tls'); | ||
const tlsSocketKeyLog = tls.connect('cause-error'); | ||
tlsSocketKeyLog.on('error', () => { | ||
setTimeout(() => { | ||
tlsSocketKeyLog.on('keylog', () => { }); | ||
}, 10); | ||
}); | ||
|
||
const tlsSocketSession = tls.connect('cause-error-2'); | ||
tlsSocketSession.on('error', (e) => { | ||
setTimeout(() => { | ||
tlsSocketSession.on('keylog', () => { }); | ||
}, 10); | ||
}); |