test: remove modifcation to common.PORT

A possibly-buggy fixture server uses `common.PORT+1000` for its port rather than `common.PORT`. That could result in it clashing with other ports if tests are run in parallel. The test runner increments `common.PORT` by 100 for each running instance for tests. Change to use common.PORT and have the tests that use the fixture start with common.PORT+1 for anything they need. PR-URL: #6990 Refs: #6989 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
nodejs · Jul 14, 2016 · 58a3852 · 58a3852
1 parent fb8232a
commit 58a3852
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/test/fixtures/clustered-server/app.js b/test/fixtures/clustered-server/app.js
@@ -31,5 +31,5 @@ if (cluster.isMaster) {
   }
 } else {
   var server = http.createServer(handleRequest);
-  server.listen(common.PORT+1000);
+  server.listen(common.PORT);
 }
diff --git a/test/parallel/test-debug-port-cluster.js b/test/parallel/test-debug-port-cluster.js
@@ -3,7 +3,7 @@ const common = require('../common');
 const assert = require('assert');
 const spawn = require('child_process').spawn;
 
-const PORT_MIN = common.PORT;
+const PORT_MIN = common.PORT + 1;  // The fixture uses common.PORT.
 const PORT_MAX = PORT_MIN + 2;
 
 const args = [

diff --git a/test/parallel/test-debug-signal-cluster.js b/test/parallel/test-debug-signal-cluster.js
@@ -3,7 +3,7 @@ var common = require('../common');
 var assert = require('assert');
 var spawn = require('child_process').spawn;
 
-var port = common.PORT + 42;
+var port = common.PORT + 1;  // The fixture uses common.PORT.
 var args = ['--debug-port=' + port,
             common.fixturesDir + '/clustered-server/app.js'];
 var options = { stdio: ['inherit', 'inherit', 'pipe', 'ipc'] };