src: expose LookupAndCompile with parameters

nodejs · Oct 26, 2022 · 5f9feee · 5f9feee
1 parent 2649aab
commit 5f9feee
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/src/node_builtins.cc b/src/node_builtins.cc
@@ -373,7 +373,6 @@ MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal(
 // Otherwise return a Local<Object> containing the cache.
 MaybeLocal<Function> BuiltinLoader::LookupAndCompile(
     Local<Context> context, const char* id, Environment* optional_env) {
-  Result result;
   std::vector<Local<String>> parameters;
   Isolate* isolate = context->GetIsolate();
   // Detects parameters of the scripts based on module ids.
@@ -424,8 +423,17 @@ MaybeLocal<Function> BuiltinLoader::LookupAndCompile(
     };
   }
 
+  return LookupAndCompile(context, id, &parameters, optional_env);
+}
+
+MaybeLocal<Function> BuiltinLoader::LookupAndCompile(
+    Local<Context> context,
+    const char* id,
+    std::vector<Local<String>>* parameters,
+    Environment* optional_env) {
+  Result result;
   MaybeLocal<Function> maybe = GetInstance()->LookupAndCompileInternal(
-      context, id, &parameters, &result);
+      context, id, parameters, &result);
   if (optional_env != nullptr) {
     RecordResult(id, result, optional_env);
   }

diff --git a/src/node_builtins.h b/src/node_builtins.h
@@ -56,6 +56,14 @@ class NODE_EXTERN_PRIVATE BuiltinLoader {
       const char* id,
       Environment* optional_env);
 
+  // A variant of LookupAndCompile where parameters are explicitly
+  // passed instead of guessed based on id pattern - used by embedders.
+  static v8::MaybeLocal<v8::Function> LookupAndCompile(
+    v8::Local<v8::Context> context,
+    const char* id,
+    std::vector<v8::Local<v8::String>>* parameters,
+    Environment* optional_env);
+
   static v8::MaybeLocal<v8::Value> CompileAndCall(
       v8::Local<v8::Context> context,
       const char* id,