-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
doc,test: empty strings in path module
The path module's `join, normalize, isAbsolute, relative and resolve` functions return/use the current directory if they are passed zero length strings. > process.version 'v2.3.4-pre' > path.win32.join('') '.' > path.posix.join('') '.' > path.win32.normalize('') '.' > path.posix.normalize('') '.' > path.win32.isAbsolute('') false > path.posix.isAbsolute('') false > path.win32.relative('', '') '' > path.posix.relative('', '') '' > path.win32relative('.', '') '' > path.posix.relative('.', '') '' > path.posix.resolve('') '/home/thefourtheye/Desktop' > path.win32.resolve('') '\\home\\thefourtheye\\Desktop' Since empty paths are not valid in any of the operating systems people normally use, this behaviour might be a surprise to the users. This commit introduces "Notes" about this, wherever applicable in `path`'s documentation. The tests makes sure that the behaviour is intact between commits. PR-URL: #2106 Reviewed-By: Rich Trott <[email protected]>
- Loading branch information
1 parent
5acad6b
commit 65963ec
Showing
2 changed files
with
55 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
'use strict'; | ||
|
||
// These testcases are specific to one uncommon behaviour in path module. Few | ||
// of the functions in path module, treat '' strings as current working | ||
// directory. This test makes sure that the behaviour is intact between commits. | ||
// See: https://github.com/nodejs/io.js/pull/2106 | ||
|
||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const path = require('path'); | ||
const pwd = process.cwd(); | ||
|
||
// join will internally ignore all the zero-length strings and it will return | ||
// '.' if the joined string is a zero-length string. | ||
assert.equal(path.join(''), '.'); | ||
assert.equal(path.join('', ''), '.'); | ||
assert.equal(path.join(pwd), pwd); | ||
assert.equal(path.join(pwd, ''), pwd); | ||
|
||
// normalize will return '.' if the input is a zero-length string | ||
assert.equal(path.normalize(''), '.'); | ||
assert.equal(path.normalize(pwd), pwd); | ||
|
||
// Since '' is not a valid path in any of the common environments, return false | ||
assert.equal(path.isAbsolute(''), false); | ||
|
||
// resolve, internally ignores all the zero-length strings and returns the | ||
// current working directory | ||
assert.equal(path.resolve(''), pwd); | ||
assert.equal(path.resolve('', ''), pwd); | ||
|
||
// relative, internally calls resolve. So, '' is actually the current directory | ||
assert.equal(path.relative('', pwd), ''); | ||
assert.equal(path.relative(pwd, ''), ''); | ||
assert.equal(path.relative(pwd, pwd), ''); |