test: refactor test-fs-readfile-unlink

* Use tmp directory instead of mutating the fixtures directory.
* Add comment explaining that the unlinkSync() at the end of the test is
  part of the test. Otherwise it may be tempting to remove it as
  unnecessary tmp directory cleanup.

PR-URL: #15173
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>

test/parallel/test-fs-readfile-unlink.js

@@ -20,22 +20,15 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-require('../common');
+const common = require('../common');
 const assert = require('assert');
 const fs = require('fs');
 const path = require('path');
-const fixtures = require('../common/fixtures');
 
-const dirName = fixtures.path('test-readfile-unlink');
-const fileName = path.resolve(dirName, 'test.bin');
+const fileName = path.resolve(common.tmpDir, 'test.bin');
 const buf = Buffer.alloc(512 * 1024, 42);
 
-try {
-  fs.mkdirSync(dirName);
-} catch (e) {
-  // Ignore if the directory already exists.
-  if (e.code !== 'EEXIST') throw e;
-}
+common.refreshTmpDir();
 
 fs.writeFileSync(fileName, buf);
 
@@ -44,6 +37,7 @@ fs.readFile(fileName, function(err, data) {
   assert.strictEqual(data.length, buf.length);
   assert.strictEqual(buf[0], 42);
 
+  // Unlink should not throw. This is part of the test. It used to throw on
+  // Windows due to a bug.
   fs.unlinkSync(fileName);
-  fs.rmdirSync(dirName);
 });