Skip to content

Commit

Permalink
src: fix readability/inheritance cpplint warnings
Browse files Browse the repository at this point in the history
PR-URL: #7462
Reviewed-By: Trevor Norris <[email protected]>
  • Loading branch information
bnoordhuis authored and Myles Borins committed Jul 14, 2016
1 parent c90ae7f commit 7852117
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
10 changes: 5 additions & 5 deletions src/async-wrap.cc
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@ class RetainedAsyncInfo: public RetainedObjectInfo {
public:
explicit RetainedAsyncInfo(uint16_t class_id, AsyncWrap* wrap);

virtual void Dispose() override;
virtual bool IsEquivalent(RetainedObjectInfo* other) override;
virtual intptr_t GetHash() override;
virtual const char* GetLabel() override;
virtual intptr_t GetSizeInBytes() override;
void Dispose() override;
bool IsEquivalent(RetainedObjectInfo* other) override;
intptr_t GetHash() override;
const char* GetLabel() override;
intptr_t GetSizeInBytes() override;

private:
const char* label_;
Expand Down
2 changes: 1 addition & 1 deletion src/cares_wrap.cc
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ class QueryWrap : public AsyncWrap {
req_wrap_obj->Set(env->domain_string(), env->domain_array()->Get(0));
}

virtual ~QueryWrap() override {
~QueryWrap() override {
CHECK_EQ(false, persistent().IsEmpty());
persistent().Reset();
}
Expand Down
2 changes: 1 addition & 1 deletion src/fs_event_wrap.cc
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class FSEventWrap: public HandleWrap {

private:
FSEventWrap(Environment* env, Local<Object> object);
virtual ~FSEventWrap() override;
~FSEventWrap() override;

static void OnEvent(uv_fs_event_t* handle, const char* filename, int events,
int status);
Expand Down
2 changes: 1 addition & 1 deletion src/handle_wrap.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class HandleWrap : public AsyncWrap {
uv_handle_t* handle,
AsyncWrap::ProviderType provider,
AsyncWrap* parent = nullptr);
virtual ~HandleWrap() override;
~HandleWrap() override;

private:
friend class Environment;
Expand Down
2 changes: 1 addition & 1 deletion src/node_stat_watcher.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace node {

class StatWatcher : public AsyncWrap {
public:
virtual ~StatWatcher() override;
~StatWatcher() override;

static void Initialize(Environment* env, v8::Local<v8::Object> target);

Expand Down

0 comments on commit 7852117

Please sign in to comment.