Skip to content

Commit

Permalink
Working on v6.2.1
Browse files Browse the repository at this point in the history 
PR-URL: #6810
  • Loading branch information
@evanlucas
evanlucas committed May 17, 2016
1 parent a4705f6 commit 7b2949a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/node_version.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@

#define NODE_MAJOR_VERSION 6
#define NODE_MINOR_VERSION 2
#define NODE_PATCH_VERSION 0
#define NODE_PATCH_VERSION 1

#define NODE_VERSION_IS_RELEASE 1
#define NODE_VERSION_IS_RELEASE 0

#ifndef NODE_STRINGIFY
#define NODE_STRINGIFY(n) NODE_STRINGIFY_HELPER(n)
Expand Down

5 comments on commit 7b2949a

@blake-regalia
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the latest v8 v5.2 make it as a dep?
Most notably, this commit will fix debugging with node-inspector: v8/v8@246d5bb

@MylesBorins
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @ofrobots I looked at backporting v8/v8@8e303dd but found we are missing test/mjsunit

Safe to assume that isn't included in our imported version of v8?

@ofrobots
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thealphanerd If you look at the v8 bug, I have requested a merge of the fix to 5.0 and 5.1 in the upstream repository. Once that is merged upstream, we should bring an update V8 version into Node rather than floating the patch.

BTW, Note that we need all the patches on the bug, not just v8/v8@8e303dd.

@ofrobots
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thealphanerd test/msjunit is indeed present in our imported version of V8: https://github.com/nodejs/node/tree/master/deps/v8/test/mjsunit.

@MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented on 7b2949a May 19, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for responding quickly and the heads up about the backport...

I was mixed up with the folder, but was specifically thinking of test/msjunit/mirror-function.js

¯_(ツ)_/¯

Let me know if I can help with anything, although it sounds like you have it covered

Please sign in to comment.